Add check for empty caller arguments in CHGBuilder::connectInheritEdgeViaCall #1788
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for empty caller argument size in constructor/destructor case
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
- Coverage 64.14% 64.14% -0.01%
==========================================
Files 243 243
Lines 24624 24626 +2
Branches 4657 4658 +1
==========================================
+ Hits 15796 15797 +1
- Misses 8828 8829 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors or destructors does not necessarily have arguments. This causes an assertion error in getConstructorThisPtr where the arguments are queried. The result of getConstructorThisPtr is used to check if the "This" pointers are the same. And because the function connectInheritEdgeViaCall returns if this is not the case, we can simply return early and avoid the error.
For posterity: this issue arose when running SVF on 483.Xalancbmk for the destructor of XSLTinit.